Skip to content

fix(schema): add typescript >=4.7 as peerDependency - #3287

Merged
daffl merged 1 commit into
feathersjs:dovefrom
Artaud:patch-1
Oct 3, 2023
Merged

daffl merged 1 commit into
feathersjs:dovefrom
Artaud:patch-1

Conversation

@Artaud

@Artaud Artaud commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Schema package doesn't compile when installed TS is below 4.7, giving cryptic errors that are hard to track down. See https://discord.com/channels/509848480760725514/1079914294323445975 for context

Schema package doesn't compile when installed TS is below 4.7, giving cryptic errors that are hard to track down.
See https://discord.com/channels/509848480760725514/1079914294323445975 for context
@Artaud

Artaud commented Sep 30, 2023

Copy link
Copy Markdown
Contributor Author

This probably doesn't need any tests, should not be a breaking change (as projects without correct version TS do not compile anyway - AFAIK it doesn't compile even with "skipLibCheck": true in tsconfig.json).

Not sure if it needs any documentation changes, but I guess not.

The main reason for this change is (at least for me) that for Feathers projects that use the client lib on the frontend with Angular, the least version of Angular needed is 14, as 13 needs typescript < 4.7.
It is definitely not rare to be on a lower version currently, and projects that are cannot use Dove client lib.
However, when they try to update, the project doesn't compile, errors are cryptic, and there's no clear indication on what's going on. This change should make it clear.

@daffl
daffl merged commit cb562ee into feathersjs:dove Oct 3, 2023
@daffl

daffl commented Oct 3, 2023

Copy link
Copy Markdown
Member

That makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants