Skip to content

fix(authentication-oauth): Prefix handling in OAuth#2773

Merged
daffl merged 4 commits into
feathersjs:dovefrom
nsainaney:dove
Oct 6, 2022
Merged

fix(authentication-oauth): Prefix handling in OAuth#2773
daffl merged 4 commits into
feathersjs:dovefrom
nsainaney:dove

Conversation

@nsainaney
Copy link
Copy Markdown
Contributor

Summary

OAuth service path ignores grant default.prefix. I am not sure if this is intentional but here's a proposed PR to fix it.

The issue is described here: #2031 (comment)

@daffl
Copy link
Copy Markdown
Member

daffl commented Oct 6, 2022

It definitely was not intentional but I was afraid I'd miss something like that in the refactoring. Thank you for this!

@daffl daffl changed the title fix: Prefix handling in OAuth fix(authentication-oauth): Prefix handling in OAuth Oct 6, 2022
@daffl daffl merged commit b1844b1 into feathersjs:dove Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants