Repository navigation
converter is not a function | 5.0.0-pre.33 | $populate #2923
Description
Steps to reproduce
(First please check that this issue is not already solved as described
here - if it is a general question or suggestion please start a Discussion)
- Tell us what broke. The more detailed the better.
- If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc. This makes it much easier for us to debug and issues that have a reproducable example will get higher priority.
When setting $populate as a filter as described at #2607 and https://dove.feathersjs.com/guides/migrating.html by setting {$populate: true}, feathers throws an error "converter is not a function." I traced the error to file node_modules/@feathersjs/adapter-commons/lib/filter-query.js, line 69. Only when I remove this from the filter, feathers works, however, prevents the usage of $populate.
Expected behavior
$populate should be an allowed filter and populates the requested data.
Actual behavior
Got error "converter is not a function"
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working): 5.0.0-pre.33
NodeJS version:
Operating System: Ubuntu
Browser Version:
React Native Version:
Module Loader:
Activity
[-]converter is not a function | 5.0.0-pre.33[/-][+]converter is not a function | 5.0.0-pre.33 | $populate [/+]palmtown commentedon Dec 18, 2022
@daffl
Great work on feathers! Just wanted to ensure that the $populate filter will be supported in v5 and if this is a bug or simply a task list item pending? If pending or a bug, do you have an estimated time when it might be completed? This will help me make decisions in the interim.
Again, great work and thank you for your time..
daffl commentedon Dec 19, 2022
Hm, I'll need to have another look at this. The goal going forward is definitely to replace all of those settings with proper query schemas because it's basically just an awkward way of doing query validation but allowing those properties should still work.
palmtown commentedon Dec 19, 2022
Hello @daffl
First, thanks for your response, much appreciated. Secondly, it surely helps to understand the direction and how to better prepare. Look forward to your update and love the work you're doing!
daffl commentedon Jan 30, 2023
This should be fixed in the latest prerelease now. As noted before, the recommended way going forward is to use a query schema to validate against.