feathers dove: default is ignored for #2776

Activity

1. daffl commented on Oct 6, 2022

   

   daffl

   on Oct 6, 2022

   Member

   More actions

   It appears this is the default AJV behaviour - to enable this, the useDefaults Ajv option needs to be set. See https://ajv.js.org/options.html#usedefaults and https://dove.feathersjs.com/api/schema/schema.html#ajv
2. prajwal497 commented on Oct 7, 2022

   

   prajwal497

   on Oct 7, 2022

   Author

   More actions

   It is already enabled and it does work on a simple structured schema with no sub or nested objects,
   but does not work for sub documents.
3. daffl commented on Oct 7, 2022

   

   daffl

   on Oct 7, 2022

   Member

   More actions

   My guess is that it is because your nested object definition should look like this:

   export const courseDataSchema = schema({
     $id: "CourseData",
     type: "object",
     additionalProperties: false,
     required: ["account", "has_certificate"], //
     properties: {
       title: { type: "string" },
       nested_obj: {
         type: "object",
         properties: {
           name: { type: "string" },
           status: { type: "string", default: "active" },
         }
       },
     },
   });
4. prajwal497 commented on Oct 10, 2022

   

   prajwal497

   on Oct 10, 2022

   Author

   More actions

   Whats the diffference?
5. daffl commented on Oct 11, 2022

   

   daffl

   on Oct 11, 2022

   Member

   More actions

   Yours is invalid JSON schema. An object definition (including nested ones) always needs to have a

   nested_obj: {
     type: "object",
     properties: {
     }
   }
6. prajwal497 commented on Oct 12, 2022

   

   prajwal497

   on Oct 12, 2022

   Last edited by prajwal497

   Author

   More actions

   Yes i may have missed that in the example but my code does have types for all sub documents (objects and arrays):
   Updated Example:

   export const courseDataSchema = schema({
       $id: 'CourseData',
       type: 'object',
       additionalProperties: false,
       required: [], //
       properties: {
         title: { type: 'string' },
         nested_obj: {
           type: 'object',
           additionalProperties: false,
           properties:{
              name: { type: 'string' },
              status: { type: 'string', default: 'active'}
           }
         }
     }
   });
   

   or

   export const courseDataSchema = schema({
     $id: 'CourseData',
     type: 'object',
     additionalProperties: false,
     required: [], //
     properties: {
       title: { type: 'string' },
       nested_array: {
         type: 'array',
         items: {
           type: 'object',
           additionalProperties: false,
           properties: {
             name: { type: 'string' },
             status: { type: 'string', default: 'active' }
           }
         }
       }
     }
   });
   
7. daffl commented on Oct 12, 2022

   

   daffl

   on Oct 12, 2022

   Member

   More actions

   This appears to still be a limitation of AJV. As noted in ajv-validator/ajv#1710 (comment) if the top level object does not exist the nested schema (and its defaults) will never be evaluated. One thing to try would be setting an empty object in a resolver before the validator runs:

   courseDataResolver = resolve({
     properties: {
       nested_obj: async value => (value || {})
     }
   })
8. prajwal497 commented on Oct 13, 2022

   

   prajwal497

   on Oct 13, 2022

   Author

   More actions

   I will test this and get back to you
9. daffl

   closed this as completedon Nov 27, 2022