Suggestion: Have whitelist_client and whitelist_server instead of whitelist #2550

Activity

1. BenZed commented on Mar 18, 2022

   

   BenZed

   on Mar 18, 2022

   More actions

   Check that there is a provider before eliminating the query param.
2. DaddyWarbucks commented on Apr 6, 2022

   

   DaddyWarbucks

   on Apr 6, 2022

   Member

   More actions

   I actually stumbled up this issue as I was checking if there was already an issue regard what I was about to post. Similar to whitelist supporting multiple providers, it would also be nice if multi did as well. I would like to allow multi on the server but not on the client. Perhaps a better syntax would be

   // Keep the old config for backwards compatibility. If the user
   // passes options like this then the whitelist/multi applies to all providers
   const options = {
     whitelist: ['$and'],
     multi: true
   }
   
   // Also allow this
   const options = {
     whitelist: {
       server: [...] // bummer, server is actually provider: undefined,
       rest: [...],
       socketio: [...]
     },
     multi:{
       server: true,
       rest: false
       socketio: false
     }
   }

   I know this can be done in hooks (and that may be better place), but this is kind of a wishlist item I guess. I will also open an issue in feathers-hooks-common to add some hooks around these two items.
3. daffl commented on Apr 25, 2022

   

   daffl

   on Apr 25, 2022

   Member

   More actions

   I'm inclined to update #2607 with adding double underscore (not super great naming but I can't think of anything better) hook-less service methods that don't do any sanitizing or validation. So basically you'd have:

   • _find, _create etc. which validates queries, filters and multi checks and passes the sanitized data to __find, __create etc.
   • __find, __create which just takes whatever you pass and rolls with it

   The reason why all sanitizing is now done in the single-underscored service methods is described in more detail in #2605. Basically I'd like people to be able to extend from the adapters and then implement the actual service methods with whatever types they want (usually just calling the _method in turn).
4. daffl

   closed this as completedin #2607on Apr 27, 2022