Hoist upgrade handler into current scope by using an arrow function (#27)

daffl · daffl · commit fea2364f33c2 · 2018-08-28T19:07:24.000-07:00
diff --git a/packages/authentication-client/src/passport.js b/packages/authentication-client/src/passport.js
@@ -52,7 +52,7 @@ export default class Passport {
       }
     });
 
-    function socketUpgradeHandler () {
+    const socketUpgradeHandler = () => {
       socket.io.engine.on('upgrade', () => {
         debug('Socket upgrading');
 
@@ -73,7 +73,7 @@ export default class Passport {
             });
         }
       });
-    }
+    };
 
     if (socket.io && socket.io.engine) {
       socketUpgradeHandler();

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export default class Passport {`
`52`	`52`	`}`
`53`	`53`	`});`
`54`	`54`
`55`		`- function socketUpgradeHandler () {`
	`55`	`+ const socketUpgradeHandler = () => {`
`56`	`56`	`socket.io.engine.on('upgrade', () => {`
`57`	`57`	`debug('Socket upgrading');`
`58`	`58`
`@@ -73,7 +73,7 @@ export default class Passport {`
`73`	`73`	`});`
`74`	`74`	`}`
`75`	`75`	`});`
`76`		`- }`
	`76`	`+ };`
`77`	`77`
`78`	`78`	`if (socket.io && socket.io.engine) {`
`79`	`79`	`socketUpgradeHandler();`