fix(koa): Only set error code for Feathers errors (#2793)

daffl · web-flow · commit d3ee41e27b0e · 2022-10-12T10:18:07.000-07:00
diff --git a/packages/koa/src/handlers.ts b/packages/koa/src/handlers.ts
@@ -1,4 +1,4 @@
-import { NotFound } from '@feathersjs/errors'
+import { FeathersError, NotFound } from '@feathersjs/errors'
 import { FeathersKoaContext } from './declarations'
 
 export const errorHandler = () => async (ctx: FeathersKoaContext, next: () => Promise<any>) => {
@@ -9,7 +9,7 @@ export const errorHandler = () => async (ctx: FeathersKoaContext, next: () => Pr
       throw new NotFound('Not Found')
     }
   } catch (error: any) {
-    ctx.response.status = error.code || 500
+    ctx.response.status = error instanceof FeathersError ? error.code : 500
     ctx.body =
       typeof error.toJSON === 'function'
         ? error.toJSON()
diff --git a/packages/koa/test/index.test.ts b/packages/koa/test/index.test.ts
@@ -199,6 +199,7 @@ describe('@feathersjs/koa', () => {
     let called = false
 
     const server = await app.listen(8787)
+
     server.on('close', () => {
       called = true
     })
