fix(transport-commons): Fix HTTP status precedence (#3511)

daffl · web-flow · commit 5d999a0acddc · 2024-07-09T17:18:10.000-07:00
diff --git a/packages/transport-commons/src/http.ts b/packages/transport-commons/src/http.ts
@@ -62,10 +62,6 @@ export function getStatusCode(context: HookContext, body: any, location: string
     return http.status
   }
 
-  if (context.method === 'create') {
-    return statusCodes.created
-  }
-
   if (location !== undefined) {
     return statusCodes.seeOther
   }
@@ -74,6 +70,10 @@ export function getStatusCode(context: HookContext, body: any, location: string
     return statusCodes.noContent
   }
 
+  if (context.method === 'create') {
+    return statusCodes.created
+  }
+
   return statusCodes.success
 }
 
diff --git a/packages/transport-commons/test/http.test.ts b/packages/transport-commons/test/http.test.ts
@@ -22,16 +22,29 @@ describe('@feathersjs/transport-commons HTTP helpers', () => {
       http: { status: 202 }
     }
     const createContext = {
+      method: 'create',
+      result: {}
+    }
+    const createEmptyContext = {
       method: 'create'
     }
     const redirectContext = {
       http: { location: '/' }
     }
+    const redirectCreateContext = {
+      method: 'create',
+      http: { location: '/' }
+    }
 
     assert.strictEqual(http.getResponse(statusContext as HookContext).status, 202)
     assert.strictEqual(http.getResponse(createContext as HookContext).status, http.statusCodes.created)
     assert.strictEqual(http.getResponse(redirectContext as HookContext).status, http.statusCodes.seeOther)
+    assert.strictEqual(
+      http.getResponse(redirectCreateContext as HookContext).status,
+      http.statusCodes.seeOther
+    )
     assert.strictEqual(http.getResponse({} as HookContext).status, http.statusCodes.noContent)
+    assert.strictEqual(http.getResponse(createEmptyContext as HookContext).status, http.statusCodes.noContent)
     assert.strictEqual(http.getResponse({ result: true } as HookContext).status, http.statusCodes.success)
   })
 

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,6 @@ export function getStatusCode(context: HookContext, body: any, location: string`
`62`	`62`	`return http.status`
`63`	`63`	`}`
`64`	`64`
`65`		`- if (context.method === 'create') {`
`66`		`- return statusCodes.created`
`67`		`- }`
`68`		`-`
`69`	`65`	`if (location !== undefined) {`
`70`	`66`	`return statusCodes.seeOther`
`71`	`67`	`}`
`@@ -74,6 +70,10 @@ export function getStatusCode(context: HookContext, body: any, location: string`
`74`	`70`	`return statusCodes.noContent`
`75`	`71`	`}`
`76`	`72`
	`73`	`+ if (context.method === 'create') {`
	`74`	`+ return statusCodes.created`
	`75`	`+ }`
	`76`	`+`
`77`	`77`	`return statusCodes.success`
`78`	`78`	`}`
`79`	`79`