fix(authentication): Omit query in JWT strategy (#2011)

daffl · web-flow · commit 04ce7e98515f · 2020-07-12T10:15:01.000-07:00
diff --git a/packages/authentication/src/jwt.ts b/packages/authentication/src/jwt.ts
@@ -94,7 +94,7 @@ export class JWTStrategy extends AuthenticationBaseStrategy {
       throw new NotAuthenticated(`Could not find entity service`);
     }
 
-    const result = await entityService.get(id, omit(params, 'provider'));
+    const result = await entityService.get(id, omit(params, 'provider', 'query'));
 
     if (!params.provider) {
       return result;
diff --git a/packages/authentication/test/jwt.test.ts b/packages/authentication/test/jwt.test.ts
@@ -75,10 +75,14 @@ describe('authentication/jwt', () => {
     app.setup();
   });
 
-  it('getEntity', async () => {
+  it('getEntity (and params.query)', async () => {
     const [ strategy ] = app.service('authentication').getStrategies('jwt') as JWTStrategy[];
 
-    let entity = await strategy.getEntity(user.id, {});
+    let entity = await strategy.getEntity(user.id, {
+      query: {
+        name: 'Dave'
+      }
+    });
 
     assert.deepStrictEqual(entity, user);
 

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ export class JWTStrategy extends AuthenticationBaseStrategy {`
`94`	`94`	throw new NotAuthenticated(`Could not find entity service`);
`95`	`95`	`}`
`96`	`96`
`97`		`- const result = await entityService.get(id, omit(params, 'provider'));`
	`97`	`+ const result = await entityService.get(id, omit(params, 'provider', 'query'));`
`98`	`98`
`99`	`99`	`if (!params.provider) {`
`100`	`100`	`return result;`