fix(authentication-oauth): Omit query from internal calls (#2398)

mrfrase3 · web-flow · commit 04c7c83eeaa6 · 2021-06-23T10:26:44.000-07:00
diff --git a/packages/authentication-oauth/src/strategy.ts b/packages/authentication-oauth/src/strategy.ts
@@ -6,7 +6,7 @@ import {
 } from '@feathersjs/authentication';
 import { Params } from '@feathersjs/feathers';
 import { NotAuthenticated } from '@feathersjs/errors';
-import { createDebug } from '@feathersjs/commons';
+import { createDebug, _ } from '@feathersjs/commons';
 
 const debug = createDebug('@feathersjs/authentication-oauth/strategy');
 
@@ -109,7 +109,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
 
     debug('createEntity with data', data);
 
-    return this.entityService.create(data, params);
+    return this.entityService.create(data, _.omit(params, 'query'));
   }
 
   async updateEntity (entity: any, profile: OAuthProfile, params: Params) {
@@ -118,7 +118,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
 
     debug(`updateEntity with id ${id} and data`, data);
 
-    return this.entityService.patch(id, data, params);
+    return this.entityService.patch(id, data, _.omit(params, 'query'));
   }
 
   async getEntity (result: any, params: Params) {
@@ -134,7 +134,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
     }
 
     return entityService.get(result[entityId], {
-      ...params,
+      ..._.omit(params, 'query'),
       [entity]: result
     });
   }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ import {`
`6`	`6`	`} from '@feathersjs/authentication';`
`7`	`7`	`import { Params } from '@feathersjs/feathers';`
`8`	`8`	`import { NotAuthenticated } from '@feathersjs/errors';`
`9`		`-import { createDebug } from '@feathersjs/commons';`
	`9`	`+import { createDebug, _ } from '@feathersjs/commons';`
`10`	`10`
`11`	`11`	`const debug = createDebug('@feathersjs/authentication-oauth/strategy');`
`12`	`12`
`@@ -109,7 +109,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {`
`109`	`109`
`110`	`110`	`debug('createEntity with data', data);`
`111`	`111`
`112`		`- return this.entityService.create(data, params);`
	`112`	`+ return this.entityService.create(data, _.omit(params, 'query'));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`async updateEntity (entity: any, profile: OAuthProfile, params: Params) {`
`@@ -118,7 +118,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {`
`118`	`118`
`119`	`119`	debug(`updateEntity with id ${id} and data`, data);
`120`	`120`
`121`		`- return this.entityService.patch(id, data, params);`
	`121`	`+ return this.entityService.patch(id, data, _.omit(params, 'query'));`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`async getEntity (result: any, params: Params) {`
`@@ -134,7 +134,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`return entityService.get(result[entityId], {`
`137`		`- ...params,`
	`137`	`+ ..._.omit(params, 'query'),`
`138`	`138`	`[entity]: result`
`139`	`139`	`});`
`140`	`140`	`}`