Skip to content

feat: Add 'send-money' and 'receive-money' and 'dashboard' icons - #714

Open
dbedoyat wants to merge 4 commits into
feathericons:mainfrom
dbedoyat:master
Open

feat: Add 'send-money' and 'receive-money' and 'dashboard' icons#714
dbedoyat wants to merge 4 commits into
feathericons:mainfrom
dbedoyat:master

Conversation

@dbedoyat

@dbedoyat dbedoyat commented Aug 8, 2019

Copy link
Copy Markdown

No description provided.

@codecov

codecov Bot commented Aug 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #714   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5047ddb...0884d0f. Read the comment docs.

@moeenio moeenio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fills are allowed.

@dbedoyat dbedoyat changed the title feat: Add 'send-money' and 'receive-money' icons feat: Add 'send-money' and 'receive-money' and 'dashboard' icons Aug 8, 2019
@moeenio

moeenio commented Aug 8, 2019

Copy link
Copy Markdown

Please read my review

@dbedoyat

dbedoyat commented Aug 8, 2019

Copy link
Copy Markdown
Author

Please read my review

Fixed! @locness3

moeenio
moeenio previously approved these changes Aug 10, 2019

@moeenio moeenio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

@moeenio

moeenio commented Aug 10, 2019

Copy link
Copy Markdown

Didn't want to approve

@dbedoyat

Copy link
Copy Markdown
Author

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

Yep, i remove the class names in 'dashboard'.

@moeenio moeenio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon in #670 ?

@dbedoyat

Copy link
Copy Markdown
Author

Maybe conforming with the banknote icon in #670 ?

According to your feedback the icon 'Banknote' has a fill in the circles.

Will you need to do similar like #670 ?

@moeenio

moeenio commented Aug 12, 2019

Copy link
Copy Markdown

According to your feedback the icon 'Banknote' has a fill in the circles.

In #670 ? It doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants