Skip to content

feat: Add flame icon#665

Open
ahtohbi4 wants to merge 2 commits intofeathericons:mainfrom
ahtohbi4:add-icon-flame
Open

feat: Add flame icon#665
ahtohbi4 wants to merge 2 commits intofeathericons:mainfrom
ahtohbi4:add-icon-flame

Conversation

@ahtohbi4
Copy link
Copy Markdown
Contributor

@ahtohbi4 ahtohbi4 commented Jul 3, 2019

Closes #449

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2019

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3c64e93) to head (b52c016).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #665   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mittalyashu
Copy link
Copy Markdown
Contributor

mittalyashu commented Jul 21, 2019

Funny thing! When I first saw this icon, it reminded me of Tinder logo 😅

Also, when I copy-paste the SVG to design app, it shows

image

There is a slight extra bump in the bottom left corner.

moeenio
moeenio previously approved these changes Jul 21, 2019
@moeenio
Copy link
Copy Markdown

moeenio commented Jul 21, 2019

It looks correct on github rich diff, and I think so it does on the web. Guess it's just a figma bug.

@mittalyashu
Copy link
Copy Markdown
Contributor

Yes, it does render properly on the web, but it should work properly in Figma too, take an example of GitHub icon, it also has the same issue.

@moeenio
Copy link
Copy Markdown

moeenio commented Jul 22, 2019

Take the globe icon, it has the same bug. Take any icon with unended paths, it has the bug. There's nothing we can do for this.

Whoops. Was in a rush and didn't saw wich issue I was on and made this comment about the Figma auto-connecting paths bug.

@ahtohbi4
Copy link
Copy Markdown
Contributor Author

Yes, the bug exists and for me, but it is solving very easy: I just selected the problem vertex, and the path closes itself:

  1. Copy SVG-code to Figma:

    Снимок экрана 2019-07-22 в 11 44 01
  2. Select the vertex:

    Снимок экрана 2019-07-22 в 11 44 10

@moeenio
Copy link
Copy Markdown

moeenio commented Jul 22, 2019

I edited my comment.

@mastro-ale
Copy link
Copy Markdown

Screenshot 2020-05-07 at 15 06 49

Can I say then that it can be done with half of the anchor points @locness3 ?

@moeenio
Copy link
Copy Markdown

moeenio commented May 7, 2020

I guess yes

@pspeter3
Copy link
Copy Markdown

I'm really excited for this icon.

@ahtohbi4
Copy link
Copy Markdown
Contributor Author

Screenshot 2020-05-07 at 15 06 49

Can I say then that it can be done with half of the anchor points @locness3 ?

Fixed.

@pspeter3
Copy link
Copy Markdown

pspeter3 commented Jun 4, 2020

Who needs to approve this?

@johnletey
Copy link
Copy Markdown

Who needs to approve this?

/cc @colebemis

@jarrodbell
Copy link
Copy Markdown

2019...wow

@AMJasser
Copy link
Copy Markdown

I'd very much appreciate adding this.

@moeenio
Copy link
Copy Markdown

moeenio commented Jun 16, 2022

This has been added in the community fork @lucide-icons FYI

@socieboy
Copy link
Copy Markdown

what's the status of this icon? more than 3 years and can't be done yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon Request: flame/fire

9 participants