Skip to content

Warn about incorrect icon name and handle gracefully #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colebemis merged 2 commits into from
May 1, 2024
Merged

Warn about incorrect icon name and handle gracefully #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5c252d
warn about incorrect icon name and handle gracefully
braden-godley Apr 30, 2024
dd20826
add changeset
braden-godley May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-balloons-breathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'feather-icons': patch
---

Feather no longer breaks when trying to replace an icon using an invalid name
5 changes: 5 additions & 0 deletions src/replace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ function replaceElement(element, attrs = {}) {
const name = elementAttrs['data-feather'];
delete elementAttrs['data-feather'];

if (icons[name] === undefined) {
console.warn(`feather: '${name}' is not a valid icon`);
return;
}

const svgString = icons[name].toSvg({
...attrs,
...elementAttrs,
Expand Down