Warn about incorrect icon name and handle gracefully#1241
Merged
colebemis merged 2 commits intofeathericons:mainfrom May 1, 2024
Merged
Warn about incorrect icon name and handle gracefully#1241colebemis merged 2 commits intofeathericons:mainfrom
colebemis merged 2 commits intofeathericons:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dd20826 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thanks for the PR, @braden-godley! Could you add a changeset for this change? |
Contributor
Author
|
will do! |
Contributor
Author
|
Changeset has been added! |
colebemis
approved these changes
May 1, 2024
Merged
This was referenced Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was running into bugs in my company's project which uses Feather. I had added an icon with the incorrect name
addsomewhere in our codebase, and it was causingfeather.replace()to completely break and not replace any icons.This PR will make it warn if you use the incorrect name and then just simply not try to replace it. This prevents the error from occurring.
Related to #443