Merged
Conversation
Member
|
@superruuuun LGTM！Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set font-display: block; into feathericon's @font-face.
Background
I found that feathericon-sass's file loading is costing time a little.
Google introduces the way to shorten font loading time by setting font-display property into @font-face,
so I suggest to introduce this solution into feathericon.
Here is the reference about it.
How to avoid showing invisible text | google web.dev
Supplement
The documentation above introduces font-display: swap; as a solution for text font, by displaying alternative font during loading.
However, in the case of icon font, which has no alternative font, font-display: block; is the optimal solution. It displays blanc object during loading.
Reference: font-display #the_font_display_timeline | MDN
For your refference, other open source icon font FontAwesome adopts font-display: block; , too.
https://github.com/FortAwesome/Font-Awesome/blob/fcec2d1b01ff069ac10500ac42e4478d20d21f4c/css/all.css#L4590