Skip to content

Load player inventory from save (#72)#97

Merged
caelunshun merged 4 commits into
feather-rs:developfrom
aramperes:feature/load-player-inventory
Aug 31, 2019
Merged

Load player inventory from save (#72)#97
caelunshun merged 4 commits into
feather-rs:developfrom
aramperes:feature/load-player-inventory

Conversation

@aramperes

@aramperes aramperes commented Aug 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #72.

@codecov

codecov Bot commented Aug 31, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #97 into develop will increase coverage by 0.25%.
The diff coverage is 81.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    54.87%   55.13%   +0.25%     
===========================================
  Files           56       56              
  Lines         7050     7128      +78     
===========================================
+ Hits          3869     3930      +61     
- Misses        3181     3198      +17
Impacted Files Coverage Δ
server/src/joinhandler.rs 30.52% <20%> (-0.94%) ⬇️
server/src/player/init.rs 90.78% <65%> (-9.22%) ⬇️
core/src/save/player_data.rs 86.32% <91.8%> (+5.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb52dc...e88e7e4. Read the comment docs.

@aramperes aramperes changed the title Load player inventory from save (#71) Load player inventory from save (#72) Aug 31, 2019
caelunshun
caelunshun requested changes Aug 31, 2019
View reviewed changes
Comment thread core/src/save/player_data.rs Outdated
caelunshun
caelunshun reviewed Aug 31, 2019
View reviewed changes
Comment thread server/src/player/init.rs Outdated
@caelunshun caelunshun merged commit 0a60a6d into feather-rs:develop Aug 31, 2019
@caelunshun

caelunshun commented Aug 31, 2019

Copy link
Copy Markdown
Member

Thanks again.

@aramperes aramperes deleted the feature/load-player-inventory branch August 31, 2019 05:16
@aramperes

aramperes commented Aug 31, 2019

Copy link
Copy Markdown
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caelunshun caelunshun caelunshun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Player data loading

2 participants

@aramperes @caelunshun