Change vanilla JAR download timeout and add warnings#474
Merged
Conversation
Member
|
Suggestion to switch to reqwest, which have better support for getting chunks. Then advancing the timer on every chunk instead of separate thread. |
Contributor
Author
|
reqwest doesn't have chunks in reqwest::blocking, and I'm not sure it's ok to do something like tokio::spawn_blocking just for a simple warning. Also, the warning is for users with bad internet connection, so they may not receive chunks or receive them with a delay, but the warning should not be delayed because of these problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change vanilla JAR download timeout and add warnings
Status
Description
Changed vanilla JAR download timeout, made it const
Added warnings when the network is very slow (with 2, 4, 6, ... minutes timeout). No one will see this because we don't have a logging frontend in feather-datapacks build script. Also, in build scripts, the stdout is only saved to target/debug/build/feather-datapacks-{hash}/output and not displayed on cargo build's stdout (except for cargo build -vv, which shows too much output to find the warning)
Related issues
#473
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.