Chunk saving#446
Merged
Merged
Conversation
Contributor
Author
|
Currently experiencing a bug that causes a chunk to get shifted 16 blocks up when unloaded and loaded later. Seems to involve fcb811d |
Contributor
Author
|
Review? |
Defman
reviewed
Aug 14, 2021
Defman
left a comment
Defman
left a comment
Member
There was a problem hiding this comment.
Looks overall good. The chunk cache unload_queue does not seem to getting filled?
Its quite a few changes, but there's nothing jumping out as being plain wrong.
Contributor
Author
|
Maybe review? Btw, should I just ping some dev every time I make changes? |
caelunshun
approved these changes
Aug 19, 2021
caelunshun
left a comment
caelunshun
left a comment
Member
There was a problem hiding this comment.
Thank you! Sorry about the delay.
Member
|
Looks like a Clippy error is blocking CI. |
mokurin000
reviewed
Aug 19, 2021
| let server = Server::bind(options).await?; | ||
|
|
||
| let game = init_game(server, config.world)?; | ||
| let game = init_game(server, &config)?; |
There was a problem hiding this comment.
let game = init_game(server, &config)?;this borrow operator should be removed
Contributor
Author
|
Build passes now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk saving
Status
Description
Chunks now get saved when they are unloaded.
Removed the WorldSource trait and a WorldGenerator and a RegionWorker are now used instead.
Related issues
#443
Checklist
cargo fmt,cargo clippy,cargo build --releaseandcargo testand fixed any generated errors!