Added Sprint Tracking#434
Merged
Merged
Conversation
ambeeeeee
approved these changes
Jun 8, 2021
Contributor
|
Provided CI passes of course |
Defman
requested changes
Jun 8, 2021
added 3 commits
June 8, 2021 21:14
Refactored the sprint detection to reduce code duplication with the assistance of Defman
The desired refactor didn't work because the method attempted couldn't receive the sprint state from the player
ThisNekoGuy
commented
Jun 9, 2021
ThisNekoGuy
left a comment
ThisNekoGuy
left a comment
Contributor
Author
There was a problem hiding this comment.
@Defman The macro doesn't approve of packet.action_id because:
- It doesn't want/expect
.("unexpected token") - and using the
==operator isn't permitted forEntityActionKind
Member
|
Sorry, I swaped the parameters of matches. It should be matches!(packet.action_id, EntityActionKind::StartSprinting). |
Turned out the macro actually expected the packet id and the `EntityActionKind` to be reversed
Contributor
Author
This works; thanks for clarifying |
Contributor
|
If it passes CI I'll merge it |
ambeeeeee
suggested changes
Jun 10, 2021
Member
|
BUMP |
Defman
approved these changes
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Sprint Tracking
Status
Description
Did the same as #428 just for sprinting instead.
Related issues
#423
Checklist
Note: Could not test plugin because of a potential compiler bug in Rust version 1.52.1
cargo fmt,cargo clippy,cargo build --releaseandcargo testand fixed any generated errors!