Fix Logging of Config#432
Merged
Merged
Conversation
ambeeeeee
approved these changes
Jun 7, 2021
Defman
requested changes
Jun 8, 2021
|
|
||
| /// Loads the config, creating a default config if needed. | ||
| pub fn load(path: &str) -> anyhow::Result<Config> { | ||
| pub fn load(path: &str) -> anyhow::Result<(Config, bool)> { |
Member
There was a problem hiding this comment.
I think the result should be wrapped in a struct, since its not clear what the bool indicates.
Defman
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logging of Config
Status
Description
Fixed logging of config after my previous pr created a small "problem" with the config loading/creating not being logged.
Checklist
cargo fmt,cargo clippy,cargo build --releaseandcargo testand fixed any generated errors!