Handle held item change packet#361
Merged
Merged
Conversation
caelunshun
reviewed
Mar 2, 2021
|
|
||
| /// The hotbar slot a player's cursor is currently on | ||
| #[derive(Debug, Clone, Copy, Eq, PartialEq)] | ||
| pub struct HotbarSlot(pub usize); |
Member
There was a problem hiding this comment.
Could we encapsulate the usize to enforce that it's always in the range 0..9? In other words, make the field private and add a setter method that returns a Result.
…k/feather into devmattrick-feat/held-item-change
…k/feather into devmattrick-feat/held-item-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic handling to held item change packets. Fixes #355.
This can be used in the future to add "get item in hand" support but I think this needs to wait on a more complete player struct api?