feather-rs · caelunshun · Jul 27, 2019 · Jul 18, 2019 · Jul 18, 2019 · Jul 21, 2019
diff --git a/.codecov.yml b/.codecov.yml
@@ -1,6 +1,6 @@
 codecov:
   notify:
-    require_ci_to_pass: no
+    require_ci_to_pass: yes
 
 ignore:
   - "blocks"
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "feather_core"
-version = "0.1.0"
+version = "0.3.0"
 authors = ["caelunshun <caelum12321@gmail.com>"]
 edition = "2018"
 

diff --git a/core/src/network/mctypes.rs b/core/src/network/mctypes.rs
@@ -1,4 +1,4 @@
-use crate::bytebuf::{BufMutAlloc, ByteBuf};
+use crate::bytebuf::{BufMutAlloc, BufResulted, ByteBuf};
 use crate::prelude::*;
 use crate::world::BlockPosition;
 use bytes::Buf;
@@ -110,7 +110,7 @@ impl<T: Buf + Read> McTypeRead for T {
             if self.remaining() == 0 {
                 return Err(());
             }
-            let read = self.get_u8();
+            let read = self.read_u8()?;
             let value = read & 0b01111111;
             result |= (value as i32) << (7 * num_read);
 
@@ -149,7 +149,7 @@ impl<T: Buf + Read> McTypeRead for T {
         if self.remaining() < 8 {
             return Err(());
         }
-        let val = self.get_u64_be();
+        let val = self.read_i64_be()?;
         let x = val >> 38;
         let y = (val >> 26) & 0xFFF;
         let z = val << 38 >> 38;
@@ -158,7 +158,7 @@ impl<T: Buf + Read> McTypeRead for T {
     }
 
     fn read_bool(&mut self) -> Result<bool, ()> {
-        let byte = self.get_u8();
+        let byte = self.read_u8()?;
         match byte {
             0 => Ok(false),
             1 => Ok(true),

diff --git a/core/src/network/packet/implementation.rs b/core/src/network/packet/implementation.rs
@@ -553,9 +553,7 @@ pub struct DisconnectLogin {
 #[derive(Default, AsAny, new, Clone)]
 pub struct EncryptionRequest {
     pub server_id: String,
-    pub public_key_len: VarInt,
     pub public_key: Vec<u8>,
-    pub verify_token_len: VarInt,
     pub verify_token: Vec<u8>,
 }
 
@@ -567,10 +565,10 @@ impl Packet for EncryptionRequest {
     fn write_to(&self, mut buf: &mut ByteBuf) {
         buf.write_string(self.server_id.as_str());
 
-        buf.write_var_int(self.public_key_len);
+        buf.write_var_int(self.public_key.len() as i32);
         buf.write(&self.public_key);
 
-        buf.write_var_int(self.verify_token_len);
+        buf.write_var_int(self.verify_token.len() as i32);
         buf.write(&self.verify_token);
     }