Skip to content

Specs refactor#19

Merged
caelunshun merged 31 commits into
developfrom
refactor
Jul 27, 2019
Merged

Specs refactor#19
caelunshun merged 31 commits into
developfrom
refactor

Conversation

@caelunshun

@caelunshun caelunshun commented Jul 21, 2019

Copy link
Copy Markdown
Member

Refactor entire codebase to use Specs instead of the homebrew ECS which is currently used.

Resolves #14.
Resolves #10.
Resolves #20.

@codecov

codecov Bot commented Jul 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #19 into develop will increase coverage by 15.7%.
The diff coverage is 57.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #19      +/-   ##
===========================================
+ Coverage    17.15%   32.86%   +15.7%     
===========================================
  Files           22       27       +5     
  Lines         3363     4543    +1180     
===========================================
+ Hits           577     1493     +916     
- Misses        2786     3050     +264
Impacted Files Coverage Δ
core/src/network/packet/mod.rs 0% <0%> (ø) ⬆️
core/src/network/packet/implementation.rs 0% <0%> (ø) ⬆️
core/src/network/mctypes.rs 0% <0%> (ø) ⬆️
server/src/chunkworker.rs 32.3% <100%> (+32.3%) ⬆️
server/src/entity.rs 14.89% <14.89%> (ø)
server/src/joinhandler.rs 27.11% <27.11%> (ø)
server/src/player.rs 33.2% <33.2%> (ø)
server/src/network.rs 36.54% <37.66%> (+36.54%) ⬆️
core/src/world/mod.rs 77.77% <40%> (-0.58%) ⬇️
server/src/main.rs 40.32% <41.25%> (+39.22%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155c8ce...b5dfb33. Read the comment docs.

@caelunshun caelunshun marked this pull request as ready for review July 26, 2019 22:41
@caelunshun caelunshun merged commit f55d9a8 into develop Jul 27, 2019
@caelunshun caelunshun deleted the refactor branch July 27, 2019 02:15
@caelunshun caelunshun mentioned this pull request Nov 13, 2019
caelunshun added a commit that referenced this pull request Mar 3, 2021
Add particle implementation to be used in feather/quill
caelunshun added a commit that referenced this pull request Mar 3, 2021
Add particle implementation to be used in feather/quill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move InitialHandler to worker thread Clean up code Status ping shows as 50ms on localhost

1 participant