Legion/Tonks rewrite#170
Merged
Merged
Conversation
Member
Author
|
Going to merge this and then reimplement old features on the master branch. |
Contributor
|
Since this has been merged. Shouldn't the README be updated? |
caelunshun
added a commit
that referenced
this pull request
Mar 24, 2020
Remove warning as #170 has been merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a total rewrite of all systems in Feather, as described in #169.
After the three previous major refactors (#62, #19, and #7), I sure hope this is the last one. I feel confident that the new architecture will be able to scale in ways which Specs could not, and any missing parts can be implemented in
tonkswithout significant refactors being required in Feather.This PR is the culmination of several months' worth of brainstorming how to circumvent the problems with the parallel ECS architecture, and I firmly believe performing this refactor is the right way to go.