Anvil world persistence#145
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #145 +/- ##
===========================================
- Coverage 61.66% 60.88% -0.79%
===========================================
Files 77 81 +4
Lines 9045 9767 +722
===========================================
+ Hits 5578 5947 +369
- Misses 3467 3820 +353
Continue to review full report at Codecov.
|
caelunshun
force-pushed
the
feature/world-persistence
branch
from
0205cf4 to
d9c289c
Compare
caelunshun
force-pushed
the
feature/world-persistence
branch
from
d9c289c to
c3f97c4
Compare
Member
Author
|
Everything appears to work. |
aramperes
reviewed
Oct 5, 2019
aramperes
approved these changes
Oct 5, 2019
Contributor
|
How is "shutdown" triggered? Is there a hook for sigint/ctrlc that sends a message in the |
Member
Author
Yes, using the ctrlc crate. The shutdown hook is set in |
cheako
pushed a commit
to cheako/feather
that referenced
this pull request
Jan 4, 2020
Resolves feather-rs#52. Features implemented: * Sector allocator for region files * RegionFile::save_chunk() * Chunk saving support for chunk worker * Periodic saving of loaded chunks (only those modified), at configurable intervals * Saving of chunks on unload and shutdown * Creation of new region files * Saving of entities * Saving of player data on disconnect and shutdown * Saving of level data This is a squashing of 23 commits: * Implement sector allocator * Implement conversion of chunk data compound to `nbt::Blob` * Initial implementation of RegionHandle::save_chunk (untested) * Initial chunk worker support for chunk saving * Save chunks upon unload * Implement periodic saving of chunks, with interval defined in config * Implement saving of chunks on shutdown * Implement creation of new region files * Save level.dat on shutdown * Begin work on entity saving * Fix saving of item entities * Add more data to chunk save so that the vanilla server accepts it * Fix panic when chunk containing players was saved * Attempt to fix Windows overflow error * Implement saving of player data on disconnect and shutdown * Fix ordering of pitch and yaw * Fix panic on double chunk unload * Fix panic when entities without position are saved * Use more idiomatic early return syntax * Implement conversion from global to section palette for chunk saving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #52.
RegionFile::save_chunk()