Skip to content

Add Synapse Launcher #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xiaoyongzhu wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add Synapse Launcher #61

xiaoyongzhu wants to merge 23 commits into from

Conversation

@xiaoyongzhu
Copy link

@xiaoyongzhu xiaoyongzhu commented Apr 25, 2021

Add Synapse Launcher (with corresponding python dependency and required changes in different files)

What this PR does / why we need it:

To add a launcher support for Synapse

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Yes


Add support for Synapse launcher

@xiaoyongzhu
Add Synapse Launcher
8a1a310 
Add Synapse Launcher (with corresponding python dependency and required changes in different files)
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Apr 25, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoyongzhu
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Apr 25, 2021

Hi @xiaoyongzhu. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Apr 25, 2021

/ok-to-test

@xiaoyongzhumsft
Merge branch 'feast-dev:master' into master
dd53a53
@xiaoyongzhumsft
Update synapse.py
9fde235 
still use service principal
@xiaoyongzhumsft
Update synapse.py
bb3d6be 
Change the authentication chain (first using Environmental variables then using device login)
@xiaoyongzhumsft
Merge branch 'feast-dev:master' into master
6885f31
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Oct 4, 2021

@xiaoyongzhu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure-presubmit 8c06c45 link /test test-end-to-end-azure-presubmit
test-end-to-end-gcp-presubmit 8c06c45 link /test test-end-to-end-gcp-presubmit
test-end-to-end-gcp 6885f31 link /test test-end-to-end-gcp
test-end-to-end-aws 6885f31 link /test test-end-to-end-aws
test-end-to-end-sparkop 6885f31 link /test test-end-to-end-sparkop

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-kind ok-to-test release-note size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiaoyongzhu @feast-ci-bot @woop @jainr @xiaoyongzhumsft