Skip to content

Cassandra as sink option for ingestion job#51

Merged
pyalex merged 7 commits intofeast-dev:masterfrom
khorshuheng:cassandra-avro
Apr 7, 2021
Merged

Cassandra as sink option for ingestion job#51
pyalex merged 7 commits intofeast-dev:masterfrom
khorshuheng:cassandra-avro

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

@khorshuheng khorshuheng commented Apr 4, 2021

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

t

What this PR does / why we need it:
Adding Cassandra as sink option for ingestion job.
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Cassandra will be available as an alternative online storage.

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
.option("max_age", config.featureTable.maxAge.getOrElse(0L))
.save()

val writer = config.store match {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be passed through spark config (in BasePipeline)?

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Apr 7, 2021

@khorshuheng: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure-presubmit 846a3b4 link /test test-end-to-end-azure-presubmit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex merged commit fc32687 into feast-dev:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants