Refactor validation spec #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshav2211
approved these changes
Jun 21, 2022
| def validate: Column | ||
| } | ||
|
|
||
| case class ExpectColumnValuesNotToBeNull(columnName: String) extends Expectation { |
Contributor
There was a problem hiding this comment.
nit: can we rename this class to exactly match with type expect_column_values_to_not_be_null
ExpectColumnValuesToNotBeNull
?
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keshav2211, khorshuheng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: khorshuheng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
refactor-validation-spec
branch
from
179711f to
57c16cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: khorshuheng khor.heng@gojek.com
What this PR does / why we need it:
Refactor the validation spec such that the validation logic is encapsulated within the expectation class itself.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: