Instantiate Jedis client lazily and only once per JVM process #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
lazy-provider
branch
2 times, most recently
from
5a0d53d to
f4c3b87
Compare
Signed-off-by: khorshuheng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
lazy-provider
branch
from
f4c3b87 to
501e27b
Compare
keshav2211
approved these changes
Jun 21, 2022
Contributor
keshav2211
left a comment
keshav2211
left a comment
There was a problem hiding this comment.
lgtm, lets keep monitoring connection errors closely
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keshav2211, khorshuheng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
added a commit
to khorshuheng/feast-spark
that referenced
this pull request
Jun 29, 2022
…feast-dev#152)" This reverts commit 58ebe0f.
khorshuheng
added a commit
to khorshuheng/feast-spark
that referenced
this pull request
Jun 29, 2022
…feast-dev#152)" This reverts commit 58ebe0f. Signed-off-by: khorshuheng <khor.heng@gojek.com>
khorshuheng
added a commit
that referenced
this pull request
Jun 29, 2022
* Revert "Instantiate Jedis client lazily and only once per JVM process (#152)" This reverts commit 58ebe0f. Signed-off-by: khorshuheng <khor.heng@gojek.com> * Revert "Retry connection failure while instantiating connection provider (#144)" This reverts commit fcb80a0. Signed-off-by: khorshuheng <khor.heng@gojek.com> Co-authored-by: khorshuheng <khor.heng@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently the Jedis client is instantiated for each partition processed, and closed after use. In production, we noticed that there are some connection leak, which we suspect is due to connections that are not cleaned properly during retries. Instantiating Jedis client only once
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: