Skip to content

Add auth support for Redis #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achals merged 2 commits into from
Oct 26, 2021
Merged

Add auth support for Redis #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be60f7c
Add auth support for redis
xiaoyongzhu Oct 26, 2021
fe4af9a
Fix format issue
xiaoyongzhu Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion serving/src/main/java/feast/serving/config/FeastProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ public RedisStoreConfig getRedisConfig() {
return new RedisStoreConfig(
this.config.get("host"),
Integer.valueOf(this.config.get("port")),
Boolean.valueOf(this.config.getOrDefault("ssl", "false")));
Boolean.valueOf(this.config.getOrDefault("ssl", "false")),
this.config.getOrDefault("password", ""));
}

public BigTableStoreConfig getBigtableConfig() {
Expand Down
5 changes: 5 additions & 0 deletions .../connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ public static RedisClientAdapter create(RedisStoreConfig config) {
if (config.getSsl()) {
uri.setSsl(true);
}

if (!config.getPassword().isEmpty()) {
uri.setPassword(config.getPassword());
}

StatefulRedisConnection<byte[], byte[]> connection =
io.lettuce.core.RedisClient.create(uri).connect(new ByteArrayCodec());

Expand Down
8 changes: 7 additions & 1 deletion ...ectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisStoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ public class RedisStoreConfig {
private final String host;
private final Integer port;
private final Boolean ssl;
private final String password;

public RedisStoreConfig(String host, Integer port, Boolean ssl) {
public RedisStoreConfig(String host, Integer port, Boolean ssl, String password) {
this.host = host;
this.port = port;
this.ssl = ssl;
this.password = password;
}

public String getHost() {
Expand All @@ -38,4 +40,8 @@ public Integer getPort() {
public Boolean getSsl() {
return this.ssl;
}

public String getPassword() {
return this.password;
}
}