Add support for on demand transforms using the Python FTS #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
adchia
reviewed
Oct 19, 2021
Contributor
adchia
left a comment
adchia
left a comment
There was a problem hiding this comment.
great stuff! general comment on refactoring that big method into submethods
serving/src/main/java/feast/serving/registry/LocalRegistryRepo.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/specs/CoreFeatureSpecRetriever.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
adchia
reviewed
Oct 19, 2021
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Contributor
|
/lgtm |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
requested changes
Oct 20, 2021
| path = deps/feast | ||
| url = https://github.com/feast-dev/feast | ||
| branch = v0.9-branch | ||
| branch = master |
Member
There was a problem hiding this comment.
this should be a specific version (probably 0.13 i guess)
Contributor
Author
There was a problem hiding this comment.
ah but aren't the transformation server protos only on master right now?
serving/src/main/java/feast/serving/config/FeastProperties.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/registry/LocalRegistryRepo.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
reviewed
Oct 21, 2021
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
deleted the
support_on_demand_transforms_with_python_fts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for on demand transformations by calling into the Python feature transformation server. See this PR for more details on the Python FTS.
I have tested this by initializing a new feature repo, adding ODFVs, starting the Python FTS, starting the Java feature server, and then confirming that the Java feature server returns the ODFVs as expected.
Signed-off-by: Felix Wang wangfelix98@gmail.com