Fix SSTable name length restrictions during retrieval #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
khorshuheng
reviewed
May 6, 2021
...sstable/src/main/java/feast/storage/connectors/sstable/retriever/SSTableOnlineRetriever.java
Show resolved
Hide resolved
Collaborator
|
/lgtm |
pyalex
reviewed
May 7, 2021
serving/src/test/java/feast/serving/it/ServingServiceBigTableIT.java
Outdated
Show resolved
Hide resolved
pyalex
reviewed
May 7, 2021
serving/src/test/java/feast/serving/it/ServingServiceBigTableIT.java
Outdated
Show resolved
Hide resolved
pyalex
reviewed
May 7, 2021
serving/src/test/java/feast/serving/it/ServingServiceBigTableIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
pyalex
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence Lim terencelimxp@gmail.com
What this PR does / why we need it:
This PR fixes retrieval failure when table name length exceeds limit:
Relevant PR at
feast-sparkrepository that addresses this issue during ingestion.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: