-
Notifications
You must be signed in to change notification settings - Fork 26
All feast types are supported by avro decoder #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
171 changes: 171 additions & 0 deletions
171
storage/api/src/main/java/feast/storage/api/retriever/AvroFeature.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright 2018-2021 The Feast Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package feast.storage.api.retriever; | ||
|
|
||
| import com.google.protobuf.ByteString; | ||
| import com.google.protobuf.Timestamp; | ||
| import feast.proto.serving.ServingAPIProto; | ||
| import feast.proto.types.ValueProto; | ||
| import java.nio.ByteBuffer; | ||
| import java.util.stream.Collectors; | ||
| import org.apache.avro.generic.GenericData; | ||
| import org.apache.avro.util.Utf8; | ||
|
|
||
| public class AvroFeature implements Feature { | ||
| private final ServingAPIProto.FeatureReferenceV2 featureReference; | ||
|
|
||
| private final Timestamp eventTimestamp; | ||
|
|
||
| private final Object featureValue; | ||
|
|
||
| public AvroFeature( | ||
| ServingAPIProto.FeatureReferenceV2 featureReference, | ||
| Timestamp eventTimestamp, | ||
| Object featureValue) { | ||
| this.featureReference = featureReference; | ||
| this.eventTimestamp = eventTimestamp; | ||
| this.featureValue = featureValue; | ||
| } | ||
|
|
||
| /** | ||
| * Casts feature value of Object type based on Feast valueType. Empty object i.e new Object() is | ||
| * interpreted as VAL_NOT_SET Feast valueType. | ||
| * | ||
| * @param valueType Feast valueType of feature as specified in FeatureSpec | ||
| * @return ValueProto.Value representation of feature | ||
| */ | ||
| @Override | ||
| public ValueProto.Value getFeatureValue(ValueProto.ValueType.Enum valueType) { | ||
| ValueProto.Value finalValue; | ||
|
|
||
| try { | ||
| switch (valueType) { | ||
| case STRING: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder().setStringVal(((Utf8) featureValue).toString()).build(); | ||
| break; | ||
| case INT32: | ||
| finalValue = ValueProto.Value.newBuilder().setInt32Val((Integer) featureValue).build(); | ||
| break; | ||
| case INT64: | ||
| finalValue = ValueProto.Value.newBuilder().setInt64Val((Long) featureValue).build(); | ||
| break; | ||
| case DOUBLE: | ||
| finalValue = ValueProto.Value.newBuilder().setDoubleVal((Double) featureValue).build(); | ||
| break; | ||
| case FLOAT: | ||
| finalValue = ValueProto.Value.newBuilder().setFloatVal((Float) featureValue).build(); | ||
| break; | ||
| case BYTES: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setBytesVal(ByteString.copyFrom(((ByteBuffer) featureValue).array())) | ||
| .build(); | ||
| break; | ||
| case BOOL: | ||
| finalValue = ValueProto.Value.newBuilder().setBoolVal((Boolean) featureValue).build(); | ||
| break; | ||
| case STRING_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setStringListVal( | ||
| ValueProto.StringList.newBuilder() | ||
| .addAllVal( | ||
| ((GenericData.Array<Utf8>) featureValue) | ||
| .stream().map(Utf8::toString).collect(Collectors.toList())) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case INT64_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setInt64ListVal( | ||
| ValueProto.Int64List.newBuilder() | ||
| .addAllVal(((GenericData.Array<Long>) featureValue)) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case INT32_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setInt32ListVal( | ||
| ValueProto.Int32List.newBuilder() | ||
| .addAllVal(((GenericData.Array<Integer>) featureValue)) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case FLOAT_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setFloatListVal( | ||
| ValueProto.FloatList.newBuilder() | ||
| .addAllVal(((GenericData.Array<Float>) featureValue)) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case DOUBLE_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setDoubleListVal( | ||
| ValueProto.DoubleList.newBuilder() | ||
| .addAllVal(((GenericData.Array<Double>) featureValue)) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case BOOL_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setBoolListVal( | ||
| ValueProto.BoolList.newBuilder() | ||
| .addAllVal(((GenericData.Array<Boolean>) featureValue)) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| case BYTES_LIST: | ||
| finalValue = | ||
| ValueProto.Value.newBuilder() | ||
| .setBytesListVal( | ||
| ValueProto.BytesList.newBuilder() | ||
| .addAllVal( | ||
| ((GenericData.Array<ByteBuffer>) featureValue) | ||
| .stream() | ||
| .map(byteBuffer -> ByteString.copyFrom(byteBuffer.array())) | ||
| .collect(Collectors.toList())) | ||
| .build()) | ||
| .build(); | ||
| break; | ||
| default: | ||
| throw new RuntimeException("FeatureType is not supported"); | ||
| } | ||
| } catch (ClassCastException e) { | ||
| // Feature type has changed | ||
| finalValue = ValueProto.Value.newBuilder().build(); | ||
| } | ||
|
|
||
| return finalValue; | ||
| } | ||
|
|
||
| @Override | ||
| public ServingAPIProto.FeatureReferenceV2 getFeatureReference() { | ||
| return this.featureReference; | ||
| } | ||
|
|
||
| @Override | ||
| public Timestamp getEventTimestamp() { | ||
| return this.eventTimestamp; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we have a new variable for this since its used here as well.