Move creation of online transformation service

felixwang9817 · felixwang9817 · commit f2c6595bffa5 · 2021-10-21T13:24:49.000-07:00
Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
diff --git a/serving/src/main/java/feast/serving/config/ServingServiceConfigV2.java b/serving/src/main/java/feast/serving/config/ServingServiceConfigV2.java
@@ -23,6 +23,7 @@
 import com.google.protobuf.AbstractMessageLite;
 import feast.serving.registry.LocalRegistryRepo;
 import feast.serving.service.OnlineServingServiceV2;
+import feast.serving.service.OnlineTransformationService;
 import feast.serving.service.ServingServiceV2;
 import feast.serving.specs.CachedSpecService;
 import feast.serving.specs.CoreFeatureSpecRetriever;
@@ -127,10 +128,12 @@ public ServingServiceV2 servingServiceV2(
     featureSpecRetriever = new CoreFeatureSpecRetriever(specService);
 
     final String transformationServiceEndpoint = feastProperties.getTransformationServiceEndpoint();
+    final OnlineTransformationService onlineTransformationService =
+        new OnlineTransformationService(transformationServiceEndpoint, featureSpecRetriever);
 
     servingService =
         new OnlineServingServiceV2(
-            retrieverV2, tracer, featureSpecRetriever, transformationServiceEndpoint);
+            retrieverV2, tracer, featureSpecRetriever, onlineTransformationService);
 
     return servingService;
   }
@@ -169,10 +172,12 @@ public ServingServiceV2 registryBasedServingServiceV2(
     featureSpecRetriever = new RegistryFeatureSpecRetriever(repo);
 
     final String transformationServiceEndpoint = feastProperties.getTransformationServiceEndpoint();
+    final OnlineTransformationService onlineTransformationService =
+        new OnlineTransformationService(transformationServiceEndpoint, featureSpecRetriever);
 
     servingService =
         new OnlineServingServiceV2(
-            retrieverV2, tracer, featureSpecRetriever, transformationServiceEndpoint);
+            retrieverV2, tracer, featureSpecRetriever, onlineTransformationService);
 
     return servingService;
   }
diff --git a/serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java b/serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
@@ -62,12 +62,11 @@ public OnlineServingServiceV2(
       OnlineRetrieverV2 retriever,
       Tracer tracer,
       FeatureSpecRetriever featureSpecRetriever,
-      String transformationServiceEndpoint) {
+      OnlineTransformationService onlineTransformationService) {
     this.retriever = retriever;
     this.tracer = tracer;
     this.featureSpecRetriever = featureSpecRetriever;
-    this.onlineTransformationService =
-        new OnlineTransformationService(transformationServiceEndpoint, featureSpecRetriever);
+    this.onlineTransformationService = onlineTransformationService;
   }
 
   /** {@inheritDoc} */
