Skip to content

Commit f06d3fb

Browse files
committed
Fix Github Action publish for Java SDK
Signed-off-by: Willem Pienaar <git@willem.co>
1 parent 58d2dd8 commit f06d3fb

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/workflows/release.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
- name: Set up Docker Buildx
6363
uses: docker/setup-buildx-action@v1
6464
- name: Login to DockerHub
65-
uses: docker/login-action@v1
65+
uses: docker/login-action@v1
6666
with:
6767
username: ${{ secrets.DOCKERHUB_USERNAME }}
6868
password: ${{ secrets.DOCKERHUB_TOKEN }}
@@ -91,7 +91,7 @@ jobs:
9191
-f infra/docker/${{ matrix.component }}/Dockerfile .
9292
docker push gcr.io/kf-feast/feast-${{ matrix.component }}:${VERSION_WITHOUT_PREFIX}
9393
docker push feastdev/feast-${{ matrix.component }}:${VERSION_WITHOUT_PREFIX}
94-
94+
9595
echo "Only push to latest tag if tag is the highest semver version $HIGHEST_SEMVER_TAG"
9696
if [ "${VERSION_WITHOUT_PREFIX}" = "${HIGHEST_SEMVER_TAG:1}" ]
9797
then
@@ -127,13 +127,15 @@ jobs:
127127
- name: Publish java sdk
128128
env:
129129
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
130+
GPG_PUBLIC_KEY: ${{ secrets.GPG_PUBLIC_KEY }}
131+
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
132+
MAVEN_SETTINGS: ${{ secrets.MAVEN_SETTINGS }}
130133
run: |
131-
echo -n ${{ secrets.GPG_PUBLIC_KEY }} > /etc/gpg/public-key
132-
echo -n ${{ secrets.GPG_PRIVATE_KEY }} > /etc/gpg/private-key
133-
echo -n ${{ secrets.MAVEN_SETTINGS }} > /root/.m2/settings.xml
134+
echo -n "$GPG_PUBLIC_KEY" > /etc/gpg/public-key
135+
echo -n "$GPG_PRIVATE_KEY" > /etc/gpg/private-key
136+
echo -n "$MAVEN_SETTINGS" > /root/.m2/settings.xml
134137
infra/scripts/publish-java-sdk.sh --revision ${VERSION_WITHOUT_PREFIX}
135138
136-
137139
publish-helm-charts:
138140
runs-on: ubuntu-latest
139141
needs: get-version

0 commit comments

Comments
 (0)