Skip to content

Commit c54fbcd

Browse files
committed
Refactoring ODFV logic into TransformationService class
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
1 parent a293978 commit c54fbcd

File tree

6 files changed

+525
-406
lines changed

6 files changed

+525
-406
lines changed

serving/src/main/java/feast/serving/config/FeastProperties.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ public void setRegistry(final String registry) {
8282
this.registry = registry;
8383
}
8484

85-
private String featureTransformationServer;
85+
private String transformationServiceEndpoint;
8686

87-
public String getFeatureTransformationServer() {
88-
return featureTransformationServer;
87+
public String getTransformationServiceEndpoint() {
88+
return transformationServiceEndpoint;
8989
}
9090

91-
public void setFeatureTransformationServer(final String featureTransformationServer) {
92-
this.featureTransformationServer = featureTransformationServer;
91+
public void setTransformationServiceEndpoint(final String transformationServiceEndpoint) {
92+
this.transformationServiceEndpoint = transformationServiceEndpoint;
9393
}
9494

9595
private CoreAuthenticationProperties coreAuthentication;

serving/src/main/java/feast/serving/config/ServingServiceConfigV2.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,11 @@ public ServingServiceV2 servingServiceV2(
126126
log.info("Created CoreFeatureSpecRetriever");
127127
featureSpecRetriever = new CoreFeatureSpecRetriever(specService);
128128

129-
final String featureTransformationServer = feastProperties.getFeatureTransformationServer();
129+
final String transformationServiceEndpoint = feastProperties.getTransformationServiceEndpoint();
130130

131131
servingService =
132132
new OnlineServingServiceV2(
133-
retrieverV2, tracer, featureSpecRetriever, featureTransformationServer);
133+
retrieverV2, tracer, featureSpecRetriever, transformationServiceEndpoint);
134134

135135
return servingService;
136136
}
@@ -168,11 +168,11 @@ public ServingServiceV2 registryBasedServingServiceV2(
168168
final LocalRegistryRepo repo = new LocalRegistryRepo(Paths.get(feastProperties.getRegistry()));
169169
featureSpecRetriever = new RegistryFeatureSpecRetriever(repo);
170170

171-
final String featureTransformationServer = feastProperties.getFeatureTransformationServer();
171+
final String transformationServiceEndpoint = feastProperties.getTransformationServiceEndpoint();
172172

173173
servingService =
174174
new OnlineServingServiceV2(
175-
retrieverV2, tracer, featureSpecRetriever, featureTransformationServer);
175+
retrieverV2, tracer, featureSpecRetriever, transformationServiceEndpoint);
176176

177177
return servingService;
178178
}

0 commit comments

Comments
 (0)