Add auth support for Redis (#43)

xiaoyongzhumsft · web-flow · commit 900add7b3823 · 2021-10-26T16:59:16.000-07:00
diff --git a/serving/src/main/java/feast/serving/config/FeastProperties.java b/serving/src/main/java/feast/serving/config/FeastProperties.java
@@ -329,7 +329,8 @@ public RedisStoreConfig getRedisConfig() {
       return new RedisStoreConfig(
           this.config.get("host"),
           Integer.valueOf(this.config.get("port")),
-          Boolean.valueOf(this.config.getOrDefault("ssl", "false")));
+          Boolean.valueOf(this.config.getOrDefault("ssl", "false")),
+          this.config.getOrDefault("password", ""));
     }
 
     public BigTableStoreConfig getBigtableConfig() {
diff --git a/storage/connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java b/storage/connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java
@@ -52,6 +52,11 @@ public static RedisClientAdapter create(RedisStoreConfig config) {
     if (config.getSsl()) {
       uri.setSsl(true);
     }
+
+    if (!config.getPassword().isEmpty()) {
+      uri.setPassword(config.getPassword());
+    }
+
     StatefulRedisConnection<byte[], byte[]> connection =
         io.lettuce.core.RedisClient.create(uri).connect(new ByteArrayCodec());
 
diff --git a/storage/connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisStoreConfig.java b/storage/connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisStoreConfig.java
@@ -20,11 +20,13 @@ public class RedisStoreConfig {
   private final String host;
   private final Integer port;
   private final Boolean ssl;
+  private final String password;
 
-  public RedisStoreConfig(String host, Integer port, Boolean ssl) {
+  public RedisStoreConfig(String host, Integer port, Boolean ssl, String password) {
     this.host = host;
     this.port = port;
     this.ssl = ssl;
+    this.password = password;
   }
 
   public String getHost() {
@@ -38,4 +40,8 @@ public Integer getPort() {
   public Boolean getSsl() {
     return this.ssl;
   }
+
+  public String getPassword() {
+    return this.password;
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,8 @@ public RedisStoreConfig getRedisConfig() {`
`329`	`329`	`return new RedisStoreConfig(`
`330`	`330`	`this.config.get("host"),`
`331`	`331`	`Integer.valueOf(this.config.get("port")),`
`332`		`- Boolean.valueOf(this.config.getOrDefault("ssl", "false")));`
	`332`	`+ Boolean.valueOf(this.config.getOrDefault("ssl", "false")),`
	`333`	`+ this.config.getOrDefault("password", ""));`
`333`	`334`	`}`
`334`	`335`
`335`	`336`	`public BigTableStoreConfig getBigtableConfig() {`