Merge pull request #3 from YikSanChan/better-use-java8-stream

khorshuheng · web-flow · commit 154db09ab04e · 2021-03-08T14:32:31.000+08:00
Make better use of java8 stream
diff --git a/core/src/main/java/feast/core/model/FeatureTable.java b/core/src/main/java/feast/core/model/FeatureTable.java
@@ -359,13 +359,13 @@ public void delete() {
 
   public String protoHash() {
     List<String> sortedEntities =
-        this.getEntities().stream().map(entity -> entity.getName()).collect(Collectors.toList());
-    Collections.sort(sortedEntities);
+        this.getEntities().stream().map(EntityV2::getName).sorted().collect(Collectors.toList());
 
-    List<FeatureV2> sortedFeatures = new ArrayList(this.getFeatures());
     List<FeatureSpecV2> sortedFeatureSpecs =
-        sortedFeatures.stream().map(featureV2 -> featureV2.toProto()).collect(Collectors.toList());
-    sortedFeatures.sort(Comparator.comparing(FeatureV2::getName));
+        this.getFeatures().stream()
+            .sorted(Comparator.comparing(FeatureV2::getName))
+            .map(FeatureV2::toProto)
+            .collect(Collectors.toList());
 
     DataSourceProto.DataSource streamSource = DataSourceProto.DataSource.getDefaultInstance();
     if (getStreamSource() != null) {
