Skip to content

Impute default project if empty before authorization is called#926

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
Cimpress-MCP:impute-default-project
Aug 7, 2020
Merged

Impute default project if empty before authorization is called#926
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
Cimpress-MCP:impute-default-project

Conversation

@jmelinav
Copy link
Copy Markdown
Collaborator

@jmelinav jmelinav commented Aug 3, 2020 •
edited
Loading

What this PR does / why we need it:
if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should authorize against default project.
Which issue(s) this PR fixes:

Related to #793

Does this PR introduce a user-facing change?:no

In 'applyFeatureSet' api, project name imputation happens before invoking authorization service. 
Previous behavior, only 'admin' user could create feature sets in 'default' project, 
and authorization was failing for users who have access to 'default' project, 
since authorization was being invoked with empty 'projectId'.

@jmelinav jmelinav requested a review from zhilingc as a code owner August 3, 2020 17:30
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Aug 3, 2020

Hi @jmelinav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav jmelinav force-pushed the impute-default-project branch from cc997fb to 041083a Compare August 3, 2020 17:40
@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Aug 3, 2020

/assign @pyalex

woop
woop reviewed Aug 4, 2020
View reviewed changes
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Aug 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelinav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Aug 5, 2020

/ok-to-test

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Aug 5, 2020

@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Aug 5, 2020

/kind bug

@woop woop added the ok-to-test label Aug 6, 2020
@woop
Copy link
Copy Markdown
Member

woop commented Aug 7, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit f537863 into feast-dev:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

@woop woop

Labels

approved kind/bug lgtm needs-ok-to-test ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmelinav @feast-ci-bot @woop @pyalex