Skip to content

Typo in feature sets example.#894

Merged
woop merged 1 commit intofeast-dev:masterfrom
ashwinath:typo-feature-sets
Jul 22, 2020
Merged

Typo in feature sets example.#894
woop merged 1 commit intofeast-dev:masterfrom
ashwinath:typo-feature-sets

Conversation

@ashwinath
Copy link
Copy Markdown
Contributor

@ashwinath ashwinath commented Jul 22, 2020

What this PR does / why we need it:
Typo in documentation.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 22, 2020

Hi @ashwinath. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwinath, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit bcb9af4 into feast-dev:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

approved needs-kind needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashwinath @feast-ci-bot @woop