Merged
Conversation
woop
requested review from
davidheryanto,
khorshuheng,
pyalex and
zhilingc
as code owners
jmelinav
reviewed
Jul 19, 2020
Collaborator
|
/lgtm |
woop
force-pushed
the
add-auth-integration-tests
branch
from
9b2d4ef to
bbc4c18
Compare
woop
force-pushed
the
add-auth-integration-tests
branch
from
52d4c2d to
280ec84
Compare
Member
Author
|
/test test-end-to-end-batch-dataflow |
pyalex
reviewed
Jul 22, 2020
core/src/test/java/feast/core/auth/CoreServiceAuthorizationIT.java
Outdated
Show resolved
Hide resolved
pyalex
reviewed
Jul 22, 2020
Member
Author
|
/test test-end-to-end-batch-dataflow |
Collaborator
|
/lgtm |
Collaborator
|
/approved |
dr3s
approved these changes
Jul 22, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dr3s, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds authentication and authorization integration tests. These tests use actual backing services like Postgres, Kafka, Keto, and a fake JWKs server to simulate a real deployment.
Will be updated and merged once #886 is merged in.
Which issue(s) this PR fixes:
Partly addresses #860, but not enough to close.
Does this PR introduce a user-facing change?: