Skip to content

Add caching to authorization#884

Merged
feast-ci-bot merged 3 commits intofeast-dev:masterfrom
Cimpress-MCP:cache-auth
Jul 21, 2020
Merged

Add caching to authorization#884
feast-ci-bot merged 3 commits intofeast-dev:masterfrom
Cimpress-MCP:cache-auth

Conversation

@jmelinav
Copy link
Copy Markdown
Collaborator

@jmelinav jmelinav commented Jul 15, 2020 •
edited by woop
Loading

What this PR does / why we need it:
Currently all requests are authorized against an external server, as this can cause latency issues in serving, Caching the authorization for a short span of time will avoid external call on subsequent requests.
Which issue(s) this PR fixes:

related to #823

Does this PR introduce a user-facing change?:No

Project level authorization access requests are now cached.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 15, 2020

Hi @jmelinav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav jmelinav force-pushed the cache-auth branch 2 times, most recently from 8be26e2 to 1d0dbe4 Compare July 17, 2020 17:20
@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Jul 17, 2020

/retest

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 17, 2020

@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Jul 17, 2020

/test ?

@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Jul 17, 2020

/test java

@jmelinav jmelinav changed the title WIP: Add Caching to authorization. Add Caching to authorization. Jul 17, 2020
@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Jul 17, 2020

/assign @davidheryanto

@mrzzy
Copy link
Copy Markdown
Collaborator

mrzzy commented Jul 18, 2020

/ok-to-test

@jmelinav
Copy link
Copy Markdown
Collaborator Author

jmelinav commented Jul 18, 2020

/test test-end-to-end-auth

woop
woop reviewed Jul 20, 2020
View reviewed changes
auth/pom.xml Outdated
Copy link
Copy Markdown
Member

@woop woop Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the formatting here please?

Copy link
Copy Markdown
Collaborator Author

@jmelinav jmelinav Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you guys use any specific formatter? I remember it happened in my last PR too.

woop
woop reviewed Jul 20, 2020
View reviewed changes
woop
woop reviewed Jul 20, 2020
View reviewed changes
@dr3s
Copy link
Copy Markdown
Collaborator

dr3s commented Jul 21, 2020

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelinav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Jul 21, 2020

/lgtm

@woop woop changed the title Add Caching to authorization. Add caching to authorization Jul 21, 2020
@feast-ci-bot feast-ci-bot merged commit 7753faf into feast-dev:master Jul 21, 2020
@jmelinav jmelinav deleted the cache-auth branch July 29, 2020 17:20
@mrzzy mrzzy mentioned this pull request Aug 2, 2020
Merged
pyalex pushed a commit that referenced this pull request Aug 2, 2020
@jmelinav
Add caching to authorization (#884)
9847b97 
* Cache authorization.

* fix formatting, removed default key generator and added a bean.

* fix rebase errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@dr3s dr3s

@davidheryanto davidheryanto

@woop woop

Labels

approved kind/techdebt lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmelinav @feast-ci-bot @mrzzy @dr3s @woop @davidheryanto