Remove historical feature in serving store#87
Conversation
|
/lgtm |
|
/lgtm cancel |
pradithya
force-pushed
the
no_historical_feature
branch
from
dcf244f to
fc28b19
Compare
pradithya
changed the title
pradithya
changed the title
pradithya
force-pushed
the
no_historical_feature
branch
from
ce63292 to
9306d02
Compare
|
/hold cancel |
|
/retest |
tims
left a comment
tims
left a comment
There was a problem hiding this comment.
I am happy with the new API, but I think we should remove timestamp range filter completely. From what I can tell it's used to filter our the returned values server side. I think we should leave that up to the user.
Other notes inline.
serving/src/main/java/feast/serving/service/BigTableFeatureStorage.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/RedisFeatureStorage.java
Outdated
Show resolved
Hide resolved
|
@tims I updated the PR to exclude server-side timestamp filtering. The timestamp filter is now done in client side. |
|
Last feedback, ts_range in the sdk should be DateTime objects not strings. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zhilingc can you please review |
pradithya
force-pushed
the
no_historical_feature
branch
from
a6d66cf to
317fdd3
Compare
|
/lgtm |
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
4 participants
Remove historical value of feature in serving store. This is incomplete solution and currently is blocked by the issue with late data overwriting newer data.
It contains breaking changes in serving and all the client will have to be updated
/hold