Compute and write metrics for rows prior to store writes#763
Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom Jun 19, 2020
Merged
Compute and write metrics for rows prior to store writes#763feast-ci-bot merged 2 commits intofeast-dev:masterfrom
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
Conversation
Collaborator
Author
|
/test test-end-to-end-batch |
Contributor
|
Does this fix #747? |
Collaborator
Author
Sort of. It provides an alternative means to monitor elements being ingested when the sink is BigQuery. |
Closed
Member
|
@zhilingc can we add this change in metrics to our documentation please? |
115d99e to
823bd9c
Compare
woop
approved these changes
Jun 19, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In PR #568, ingestion metrics were shifted to be computed and written post-store-writes, in order to accurately reflect the values that are actually available to users.
However, for certain stores (like BQ), successfully written rows cannot be retrieved post-write, and as a result feature row metrics are not produced for ingestion jobs writing to such stores. This PR re-introduces inflight feature row metrics as an alternative source of monitoring.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: