Skip to content

Update Example Notebooks to Default Project and Update Feature Refrences#743

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
mrzzy:update-example-notebooks-v0-5
May 28, 2020
Merged

Update Example Notebooks to Default Project and Update Feature Refrences#743
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
mrzzy:update-example-notebooks-v0-5

Conversation

@mrzzy
Copy link
Copy Markdown
Collaborator

@mrzzy mrzzy commented May 27, 2020

What this PR does / why we need it:
Updates the example notebooks to v0.5 Python SDK post PR #693

  • removes manual setting of projects (default to default project).
  • update feature references in the format from project/feature to feature.

@mrzzy mrzzy changed the title Update example notebooks v0 5 Update Example Notebooks to Default Project and Update Feature Refrences May 27, 2020
@mrzzy mrzzy added the kind/bug label May 27, 2020
@woop woop added the kind/bug label May 27, 2020
@woop
Copy link
Copy Markdown
Member

woop commented May 27, 2020

/lgtm
/approve

@woop
Copy link
Copy Markdown
Member

woop commented May 28, 2020

/retest

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrzzy, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 75400fe into feast-dev:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants