Add computation and retrieval of batch feature statistics#741
Merged
zhilingc merged 11 commits intofeast-dev:masterfrom Jun 9, 2020
Merged
Add computation and retrieval of batch feature statistics#741zhilingc merged 11 commits intofeast-dev:masterfrom
zhilingc merged 11 commits intofeast-dev:masterfrom
Conversation
zhilingc
requested review from
davidheryanto,
khorshuheng,
pyalex and
woop
as code owners
zhilingc
force-pushed
the
batch-query-get-stats-api-2
branch
2 times, most recently
from
5567ce1 to
7115066
Compare
Collaborator
Author
|
/test test-end-to-end |
zhilingc
force-pushed
the
batch-query-get-stats-api-2
branch
from
7115066 to
2782cff
Compare
added 10 commits
June 9, 2020 10:41
zhilingc
force-pushed
the
batch-query-get-stats-api-2
branch
from
2782cff to
1b52bc2
Compare
woop
approved these changes
Jun 9, 2020
Member
|
/lgtm |
Collaborator
Author
|
/test test-end-to-end |
Collaborator
Author
|
/approve |
Collaborator
|
/approve |
woop
approved these changes
Jun 9, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resubmission of #612, rebased on master.
This PR adds support for retrieval of batch statistics over data ingested into a feast warehouse store, as proposed in M2 of the Feature Validation RFC.
Note that it deviates from the RFC in the following ways:
This is a bit of a chonky PR, but refer to the attached notebook for how this implementation looks like for a user of Feast.
Does this PR introduce a user-facing change?: