Skip to content

v0.5 backport: Restore SDK and Ingestion compatibility with Java 8 runtimes#739

Merged
woop merged 1 commit intov0.5-branchfrom
v0.5-backport-722
May 23, 2020
Merged

v0.5 backport: Restore SDK and Ingestion compatibility with Java 8 runtimes#739
woop merged 1 commit intov0.5-branchfrom
v0.5-backport-722

Conversation

@ches
Copy link
Copy Markdown
Member

@ches ches commented May 23, 2020

What this PR does / why we need it:

Backports #722 to v0.5.

Does this PR introduce a user-facing change?:

- Restores Feast Ingestion compatibility with Java 8 runtimes
- Restores Feast Java SDK compatibility with Java 8 runtimes

@ches ches added kind/bug area/ingestion The ingestion Beam component and storage-related items area/sdks labels May 23, 2020
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented May 23, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ches
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ches
Copy link
Copy Markdown
Member Author

ches commented May 23, 2020

Hmm probably we also need to backport #725, and perhaps #728.

@ches
Copy link
Copy Markdown
Member Author

ches commented May 23, 2020

/retest

Maven Central connection blip it seems

@woop
Copy link
Copy Markdown
Member

woop commented May 23, 2020 •
edited
Loading

Those tests dont add any value here I think. They are testing the current master branch. I've removed them from all non-master branches and all PRs. So they only trigger on a push to master and we can track them through the front page badge.

Wait a minute, they shouldn't have run on a PR in the first place. Strange.

@woop woop merged commit de0a614 into v0.5-branch May 23, 2020
@ches
Copy link
Copy Markdown
Member Author

ches commented May 23, 2020

Wait a minute, they shouldn't have run on a PR in the first place. Strange.

I'd guess it's that b8456c1 isn't on v0.5-branch—my interpretation of this is that a pull request event is probably associated with the target branch as its Git ref, so the workflow configurations from the branch head will apply.

@ches ches deleted the v0.5-backport-722 branch May 23, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto davidheryanto is a code owner

@khorshuheng khorshuheng Awaiting requested review from khorshuheng khorshuheng is a code owner

@pradithya pradithya Awaiting requested review from pradithya pradithya is a code owner

@woop woop Awaiting requested review from woop woop is a code owner

@zhilingc zhilingc Awaiting requested review from zhilingc zhilingc is a code owner

Assignees

No one assigned

Labels

area/ingestion The ingestion Beam component and storage-related items area/sdks kind/bug size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ches @feast-ci-bot @woop