Remove unused Hibernate dep from Serving#721
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ches The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @davidheryanto |
|
Flaky tests are killing me. |
|
I tried one rerun of the Docker Compose workflow, still got timeouts. Looks like it's failing on every recent PR. |
Ah, it's supposed to be failing. Yay. So it's not flakiness, it's due to not updating the SDK to the latest version. Will have a look a bit later. And documentation is still pending for me. |
|
/lgtm |
I believe I have fixed the docker compose test, but for some reason your test isnt using the code that is on the master branch. It should be cloning the I think you should maybe just rebase and try again. Might be smarter to only run these Docker Compose tests on master and not on PRs. |
|
New changes are detected. LGTM label has been removed. |
|
/retest Docker Compose Actions workflow still appears to time out. |
What this PR does / why we need it:
Removes an unused dependency. Just a little housekeeping noticed in the context of something related. Core and Serving were using different versions of Hibernate, which I first wanted to align, then thought to myself, "wait, how does Serving use Hibernate?"
Maybe someone knows the background of what "Hibernate for formatting SQL string" meant, but grepping/
mvn dependency:analyze/building suggests it is indeed unused.Which issue(s) this PR fixes:
No issue
Does this PR introduce a user-facing change?: