Remove feature set update from job update cycle#711
Remove feature set update from job update cycle#711zhilingc wants to merge 6 commits intofeast-dev:masterfrom
Conversation
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhilingc
force-pushed
the
jobs-no-update-fs
branch
from
35297db to
e05f014
Compare
zhilingc
force-pushed
the
jobs-no-update-fs
branch
from
5beabcc to
c58a617
Compare
|
/test test-end-to-end |
|
@zhilingc: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR is broken after rebase 😿 |
|
Let's pick this up in the future if its necessary. Made somewhat redundant by #792. |
3 participants
What this PR does / why we need it:
Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long periods of time. Hopefully this improves the performance of the system.
The responsibility of making feature set status updates is pushed to when the feature set is retrieved (either by ListFeatureSets or GetFeatureSet).
Would like the dataflow tests to be fixed and run on this PR before this is merged in, ideally.
Which issue(s) this PR fixes:
Fixes #664
Does this PR introduce a user-facing change?: