fix: Isolate default user permissions - #6729
Merged
ntkathole merged 1 commit intoAug 14, 2026
Merged
Conversation
Nikhi00718
marked this pull request as ready for review
August 12, 2026 12:29
ntkathole
approved these changes
Aug 14, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6729 +/- ##
==========================================
- Coverage 46.81% 46.80% -0.01%
==========================================
Files 415 415
Lines 50399 50399
Branches 7214 7214
==========================================
- Hits 23592 23591 -1
Misses 25157 25157
- Partials 1650 1651 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: NIKHIL <atnikhil06@gmail.com>
ntkathole
force-pushed
the
fix/independent-user-permissions
branch
from
August 14, 2026 06:18
c1cd49b to
3199ae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Userpreviously used three mutable list objects as constructor defaults. All users created without explicit permissions therefore shared the same roles, groups, and namespaces lists. Mutating one user's default collection could unexpectedly change another user's effective authorization state.This change creates a fresh list for each omitted permission collection and adds a regression test covering all three fields. Explicitly supplied lists keep the existing behavior.
Which issue(s) this PR fixes:
No existing issue or pull request matched this bug. The draft PR starts the discussion as allowed by Feast's contribution guide.
Checks
git commit -s)Testing Strategy
Validation performed:
uvx ruff check sdk/python/feast/permissions/user.py sdk/python/tests/unit/permissions/test_user.pyuvx ruff format --check sdk/python/feast/permissions/user.py sdk/python/tests/unit/permissions/test_user.pyThe repository's full unit-test environment did not finish resolving within the local execution window, so that limitation is documented here and the broader suite is left to CI.
Misc
Release note
AI assistance disclosure
I identified and reproduced the issue, then used OpenAI Codex to assist with the implementation and regression-test work. I personally reviewed the resulting diff and ran the validation commands listed above to verify the fix. Any full-suite or local-environment limitations are documented in the validation section.